search

mavlink / MAVSDK-Java

MAVSDK client for Java.
71 stars 41 forks source link

`LogFiles#getDownloadLogFile` method doesn't work as expected #68

Closed divyanshupundir closed 3 years ago

divyanshupundir commented 3 years ago

This is the signature of the download log file method in log_files package in the Java version:

public Flowable<LogFiles.ProgressData> getDownloadLogFile()

And this is the corresponding one in Python:

async def download_log_file(self, entry, path):

The Java one doesn't have any parameters for entry and path and always throws FILE_OPEN_FAILED: File Open Failed error when I try to use it.

julianoes commented 3 years ago

Thanks for reporting @divyanshu1234. This looks indeed wrong, right @JonasVautherin?

JonasVautherin commented 3 years ago

Should be fixed in latest main. @divyanshu1234 could you give it a try? Then I could make a new release with those changes :+1:

Note: I added an example here

divyanshupundir commented 3 years ago

I tried downloading a few logs using SITL and it is working fine. I will not be able to try it on hardware this week. But I've hardly ever faced any issue with MAVSDK that emerged using hardware that wasn't there in SITL.

Thanks for the fix.

JonasVautherin commented 3 years ago

Ok let's close it then, it will come in the next release (I'll try to create a release today or tomorrow)