search

mavlink / MAVSDK-docs

MAVSDK Guide Docs - Source Code
https://mavsdk.mavlink.io
Other
24 stars 37 forks source link

contributing: use documented -S instead of -H #199

Closed julianoes closed 4 years ago

julianoes commented 4 years ago

-H is an undocumented cmake flag that we should not rely upon.

See: https://stackoverflow.com/a/54279862/8548472

JonasVautherin commented 4 years ago

See my comment in https://github.com/mavlink/MAVSDK/pull/1090. I used -H where -S was failing, not sure if that is solved everywhere. -S will work everywhere at some point, but it seems to me that -H is legacy, and in some cases needed (because it's still much nicer than mkdir build && cd build && cmake IMO).

julianoes commented 4 years ago

Ok, so the issue might be with cmake 3.5.1 on Ubuntu 16.04.

So in that case it might be correct to use -H everywhere until we drop support for 16.04.

TSC21 commented 4 years ago

Ok, so the issue might be with cmake 3.5.1 on Ubuntu 16.04.

So in that case it might be correct to use -H everywhere until we drop support for 16.04.

Btw I am using Ubuntu 18.04 and I can't seem to use -S.

julianoes commented 4 years ago

Let's leave it as is with -H.