search

mavlink / c_uart_interface_example

Simple MAVLink to UART interface example for *nix systems
264 stars 257 forks source link

Proposed changes branch #8

Closed aerialhedgehog closed 9 years ago

aerialhedgehog commented 9 years ago

merging jaycee's changes

LorenzMeier commented 9 years ago

Hi,

Great! I think this is an important contribution to make the first steps with off board control a lot easier for new people, and to allow the development community to quickly validate changes without the need to have a complete ROS stack configured and running.

There are a couple of things that would benefit from cleanup:

aerialhedgehog commented 9 years ago

Doh i meant to pull this into our master, was wondering why i couldnt approve it! The comments are good to have thanks Lorenz! Thanksgiving is tomorrow here so I'll be back on this in two days.

Hi,

Great! I think this is an important contribution to make the first steps with off board control a lot easier for new people, and to allow the development community to quickly validate changes without the need to have a complete ROS stack configured and running.

There are a couple of things that would benefit from cleanup:

  • Add the Eclipse (.project, .cproject, etc.) files to the .gitignore file and remove them here.
  • Remove the complete build directory. This is also an Eclipse thing that should be only on your local machine
  • Remove the mavlink/include/mavlink/v1.0/_bak folder. The backup is in the GIT history, no need to clutter the working tree.

— Reply to this email directly or view it on GitHub https://github.com/mavlink/c_uart_interface_example/pull/8#issuecomment-64717990 .

yassiezar commented 9 years ago

Lorenz,

I went ahead and committed the changes you've proposed into the repo

aerialhedgehog commented 9 years ago

Lorenz what is the best way you like to provide project files? These help new developers get off the ground faster in my opinion.

Lorenz,

I went ahead and committed the changes you've proposed into the repo

— Reply to this email directly or view it on GitHub https://github.com/mavlink/c_uart_interface_example/pull/8#issuecomment-64743490 .

aerialhedgehog commented 9 years ago

going to move this to a different request