search

mavlink / c_uart_interface_example

Simple MAVLink to UART interface example for *nix systems
264 stars 257 forks source link

updated uart example, uses classes #9

Closed aerialhedgehog closed 9 years ago

aerialhedgehog commented 9 years ago

a note - this pull request currently cuts throttle in the middle of the offboard commands for xyz lacal_ned position. attaching a plot of the servo commands for this behavior.

servo_out

LorenzMeier commented 9 years ago

Cool, thanks! Could you split this PR into one MAVLink update PR predating this and then a PR with just the core changes? Its impossible to review in the current shape due to the massive diff.

aerialhedgehog commented 9 years ago

hey lorenz, i'm trying to do the separate pr's but the mavlink changes in my branch are pretty mixed up. i'll submit a request that adds the gitmodule, but right now i'm still seeing a big diff with the present pr -- https://github.com/aerialhedgehog/c_uart_interface_example/compare/aerialhedgehog:object...mavlink_branch

aerialhedgehog commented 9 years ago

maybe after i merge the other pr this will clean up.

aerialhedgehog commented 9 years ago

also i'm not sure how you manage author lists, happy to change things around if this isn't right

LorenzMeier commented 9 years ago

Could you update this one with master (which has the submodule?) I think we're good to go then.

aerialhedgehog commented 9 years ago

ready to go!

LorenzMeier commented 9 years ago

Thanks, great! Sorry for our lag on feedback!

@thomasgubler Feedback welcome :)

LorenzMeier commented 9 years ago

Wow, this is awesome work, and awesome docs. I'm really impressed and the community will appreciate this!

aerialhedgehog commented 9 years ago

Cool beans! Was a team effort :)