search

mavlink / mavlink-camera-manager

MAVLink Camera Manager Service
MIT License
103 stars 30 forks source link

RTSP is not working with QGC #114

Closed joaoantoniocardoso closed 2 years ago

joaoantoniocardoso commented 2 years ago

The problem is very straightforward:

As consequence, the user will never be able to have the QGC connect to the RTSP stream, only if using an additional redirect stream advertising the adapter IP.

Overall this IP thing was quite confusing to me at the beginning, and it might be as well for the end user: while UDP only works using the network IP (like 192.168.2.1), RTSP only works when using the adapter IP (like 192.168.2.2) - will the users know what to choose?

I see two ways to solve this and keep consistency: A. Just allow the user to choose any IP for RTSP streams, which is what we are doing for any other stream, which isn't a big deal until now. B. Choose the correct IP for each stream kind, instead of asking for the user to be an expert.

Today the user has to enter the correct IP for each stream kind he is setting up otherwise the stream will never work. Is there any specific reason (that I'm not seeing) for us to ask for the right IP for the users, instead of programmatically choosing the right one for them?

joaoantoniocardoso commented 2 years ago

Right now, we are choosing to leave the responsibility for the front-end - the front-end should implement their own logic to solve this confusing setup. The BlueOs has implemented a good example (see https://github.com/bluerobotics/BlueOS-docker/pull/1125).

Since #115 this issue is not a bug anymore, so I'm closing it.

patrickelectric commented 2 years ago

We can provide a mdns for QGC find the IP

On Mon, Aug 29, 2022, 13:17 João Antônio Cardoso @.***> wrote:

Right now, we are choosing to leave the responsibility for the front-end - the front-end should implement their own logic to solve this confusing setup. The BlueOs has implemented a good example (see bluerobotics/BlueOS-docker#1125 https://github.com/bluerobotics/BlueOS-docker/pull/1125).

Since #115 https://github.com/bluerobotics/mavlink-camera-manager/pull/115 this issue is not a bug anymore, so I'm closing it.

— Reply to this email directly, view it on GitHub https://github.com/bluerobotics/mavlink-camera-manager/issues/114#issuecomment-1230535401, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJIYCJNTZRF24XHKQGGLBLV3TPCLANCNFSM56XU32UA . You are receiving this because you are subscribed to this thread.Message ID: @.***>