mavlink / mavlink-camera-manager

MAVLink Camera Manager Service

MIT License

96 stars 30 forks source link

No errors when creating a stream with wrong Size/FPS #79

Open joaoantoniocardoso opened 2 years ago

joaoantoniocardoso commented 2 years ago

Related to #78.

When creating a stream using the wrongly associated Size/FPS for YUYV (eg. 1920x1080@30FPS), no errors are returned, and neither new stream populates the Stream list, but when trying to create another stream, it returns two possible errors:

Stream name already in use
Device already in use

Thus, indicating a bug on the back-end side.

joaoantoniocardoso commented 1 year ago

172 partially fixes the problem, but the error returned isn't good enough:

"Failed to add Sink of type UDP to the Pipeline. Reason: Failed setting Pipeline 283ec88f-3c8d-40a2-8ac8-2e10aaca8246 to Null state. Reason: set state timed-out (2 seconds)"

So we should add a validator to check camera capabilities before creating the v4l pipeline.