search

mavlink / mavros

MAVLink to ROS gateway with proxy for Ground Control Station
Other
902 stars 993 forks source link

ROS2: port mavros scripts #1563

Closed vooon closed 3 years ago

vooon commented 3 years ago

Need to port scripts to python3 and ros2. Also would use single entry point.

akvavit01 commented 3 years ago

Hi, is there any progress in this task? I would like to contribute on porting MAVROS to ROS2

vooon commented 3 years ago

Hi. I;m currently working on new python client library. Perhaps would get first scripts soon.

See: https://github.com/mavlink/mavros/tree/ros2/mavros/mavros

Also i found out that current param plugin doesn't work well - i have to redo service interface by myself and not rely on rclcpp provided one.

akvavit01 commented 3 years ago

Can I trouble you to explain about the param plugin? Is the one that's not working the parser?

akvavit01 commented 3 years ago

By the way, will there be any plan to port the code into c++? As far as I know, c++ is better in terms of performance

vooon commented 3 years ago

No, param is working, just having some bugs which i need to fix...

Mavros node is written in C++, for helper cli's like mavparam/mavwp performance is not an issue, so i do not see any reason to rewrite.

akvavit01 commented 3 years ago

Okay Is there anything that can be done in parallel?

vooon commented 3 years ago

Actually you could start porting of mavros_extras, that's entirely untouched ground.

akvavit01 commented 3 years ago

Okay, will do it after my laptop has beem repaired Best of luck to you, sir

vooon commented 3 years ago

Done.