mavlink / mavros

MAVLink to ROS gateway with proxy for Ground Control Station
Other
847 stars 983 forks source link

Update configuration files in launch directory #1916

Open hasanosman601 opened 8 months ago

hasanosman601 commented 8 months ago

Removed '/**' in namespace/node_name of parameters in configuration files that located under ./mavros/launch/ directory

This commit modifies the configuration files in the launch directory of the MAVROS package. The '/**' in namespace/node_name of parameters were removed to ensure proper configuration. The specific changes were made in these files: ./mavros/launch/apm_config.yaml ./mavros/launch/apm_pluginlists.yaml ./mavros/launch/px4_config.yaml ./mavros/launch/px4_pluginlists.yaml

hasanosman601 commented 8 months ago

this PR related to #1912 issue

vooon commented 8 months ago

Please try approach from #1915

hasanosman601 commented 8 months ago

Please try approach from #1915

this approach didn't work for me, all parameters still take default values

vooon commented 8 months ago

Strange. Soryr, what ros2 release you're on?

hasanosman601 commented 8 months ago

@vooon Foxy release because I'm using ubunut20, but I looked at the documentation for both the Foxy and Humble release about parameters as they have the same documentation so I don't know if the issue is related to the Ros2 distribution I'm using

vooon commented 8 months ago

@hasanosman601 that's unclear, but some features changes quite hard comparing to older releases.

hasanosman601 commented 8 months ago

@vooon ok, I'll keep this change since it works for me on Foxy release.