Closed MaEtUgR closed 3 years ago
@MaEtUgR Looks great. I'm going to merge, but I have open question in here related to "Use parallel clone commands" - i.e. how much value do they really add vs can they break anything?
@hamishwillee Cool, thanks. We should also get https://github.com/mavlink/qgroundcontrol/pull/9386 going for the script 👍
how much value do they really add vs can they break anything?
Parallel cloning has the most value if you have a whole submodule tree and a fast internet connection. E.g. on the PX4 repo, the cloning time can be reduced to a fraction. Instead of going through submodules one by one, it starts multiple threads that clone them in parallel which is much more efficient because cloning is a sequence of downloading git objects and checking them out locally. Also, you usually get faster download speeds that way. A potential disadvantage is if your internet goes down during cloning it could theoretically happen that you end up with no finished submodule instead of the first few.
But it still works fine if you don't have 8 cores?
But it still works fine if you don't have 8 cores?
Yes, sure. It uses multiple threads and also works with one core.
Also this merge conflicts with my other comments and the arch setup script which is incorrect. The only thing that script can do correctly is install speech-dispatcher. So I don't think there is much worth to it.
Since I started building QGC I wanted to document how to build and run it from the command line. FYI @hamishwillee I don't have write access so it's on my fork.