search

mavlink / qgc-user-guide

QGroundControl User Guide (Gitbook source)
https://docs.qgroundcontrol.com/en/
Other
43 stars 78 forks source link

Add very cool PID tuning stuff #136

Closed hamishwillee closed 5 years ago

hamishwillee commented 6 years ago

Add docs: https://github.com/mavlink/qgroundcontrol/pull/6295

jaxxzer commented 5 years ago

There is also a tuning page available for ArduSub. We have yet to add support for ArduPilot generally, but I think it would be straightforward.

Note the ardusub tuning page is not quite as sophisticated as this support for PX4, but we could work on that too.

hamishwillee commented 5 years ago

@jaxxzer

We have yet to add support for ArduPilot generally, but I think it would be straightforward.

I presume you mean this in response to Don's comment below

The above currently is only supported for PX4 Pro firmware and multi-rotors. But that said the whole thing is implemented in a generic fashion such that it just works off of generic lists of parameters. So all I need to do is figure out what all the other param sets are to implement other vehicle types and ArduPilot support.

Should the sub page be implemented using this new feature instead? How do we get the params Don needs for this for the various ArduPilot vehicle types?

Can you recommend best person to document the tuning page for Sub?I don't know enough about Sub tuning to do a good job but I'd happily subedit.

jaxxzer commented 5 years ago

Hi there @hamishwillee. @Williangalvani and I will be able to help you with anything sub-related.

Should the sub page be implemented using this new feature instead? How do we get the params Don needs for this for the various ArduPilot vehicle types?

A possibility, yes. We will take a shot at it.

hamishwillee commented 5 years ago

Thanks @jaxxzer !