mavlink / qgroundcontrol

Cross-platform ground control station for drones (Android, iOS, Mac OS, Linux, Windows)
http://qgroundcontrol.io
3.19k stars 3.53k forks source link

ToolDrawer back icon incorrect #11248

Closed ben-draper-ascent closed 6 months ago

ben-draper-ascent commented 6 months ago
 function showPlanView() {
      planView.visible = true
  }

  function showFlyView() {
      planView.visible = false
  }

  function showTool(toolTitle, toolSource, toolIcon) {
      toolDrawer.backIcon     = flyView.visible ? "/qmlimages/PaperPlane.svg" : "/qmlimages/Plan.svg"
      toolDrawer.toolTitle    = toolTitle
      toolDrawer.toolSource   = toolSource
      toolDrawer.toolIcon     = toolIcon
      toolDrawer.visible      = true
  }

I believe the code from commit e3b536f as seen here will break the showTool function because flyview will now always be visible?

ben-draper-ascent commented 6 months ago

Will not be an issue if https://github.com/mavlink/qgroundcontrol/pull/11250 is merged