mavlink / qgroundcontrol

Cross-platform ground control station for drones (Android, iOS, Mac OS, Linux, Windows)
http://qgroundcontrol.io
3.27k stars 3.6k forks source link

Selecting 'MapBox' Map provider not displaying 3d buildings #11610

Closed ashokbugude closed 4 months ago

ashokbugude commented 4 months ago

The following template is for Issue/Bug reporting only. https://docs.qgroundcontrol.com/en/Support/Support.html#github-issues

For questions about how to use or build QGC see: http://qgroundcontrol.com/#resources

If you are using an old stable release please upgrade first and verify your issue before reporting.

Expected Behavior

Please tell us what should happen as detailed as possible.

MapBox map should display 3d buildings

Current Behavior

Please describe what happens instead of the expected behavior. MapBox map is not displaying 3d buildings

Steps to Reproduce:

Please provide an unambiguous set of steps to reproduce the current behavior

  1. Customize the following map settings Provider - MapBox Type - Custom Tokens -> Mapbox - pk.eyJ1IjoiYXNob2tidWd1ZGUtY29kdm8iLCJhIjoiY2x4YWYyaGR3MDN3ZTJsczN5NHoyZmtseCJ9.uPg7ST-wx2BNTCRitmDEWg Account - ashokbugude-codvo Map Style - clxbmwl1o00r001qqe5mq352f Map url - https://api.mapbox.com/styles/v1/ashokbugude-codvo/clxbmwl1o00r001qqe5mq352f.html?title=view&access_token=pk.eyJ1IjoiYXNob2tidWd1ZGUtY29kdm8iLCJhIjoiY2x4YWYyaGR3MDN3ZTJsczN5NHoyZmtseCJ9.uPg7ST-wx2BNTCRitmDEWg&zoomwheel=true&fresh=true#15.48/40.744096/-73.988742/2.6/55

System Information

When posting bug reports, include the following information

Detailed Description

Provide further details about your issue/bug. MapBox map is not displaying 3d buildings

Log Files and Screenshots

Current map in GQC

image
HTRamsey commented 4 months ago

Did you have an API key entered? It's tough for me to test maps w/o keys but should be easy to fix if there's an issue, but I don't see anything obvious at the moment.

Also @bkueng @DonLakeFlyer this reminds me of something related to my recent QtLocationPlugin stuff. Previously only VWorld showed Bing as a back up if the API key was not entered or incorrect which seemed kinda misleading to me. Should I re-add that? Seems like there should either be no backup or a common one, otherwise the user has no idea what maps they are actually using.

ashokbugude commented 4 months ago

@HTRamsey I have used the following values

Provider - MapBox Type - Custom Tokens -> Mapbox - pk.eyJ1IjoiYXNob2tidWd1ZGUtY29kdm8iLCJhIjoiY2x4YWYyaGR3MDN3ZTJsczN5NHoyZmtseCJ9.uPg7ST-wx2BNTCRitmDEWg Account - ashokbugude-codvo Map Style - clxbmwl1o00r001qqe5mq352f Map url - https://api.mapbox.com/styles/v1/ashokbugude-codvo/clxbmwl1o00r001qqe5mq352f.html?title=view&access_token=pk.eyJ1IjoiYXNob2tidWd1ZGUtY29kdm8iLCJhIjoiY2x4YWYyaGR3MDN3ZTJsczN5NHoyZmtseCJ9.uPg7ST-wx2BNTCRitmDEWg&zoomwheel=true&fresh=true#15.48/40.744096/-73.988742/2.6/55

I have compiled from source code and added values in the UI. Its not displaying blank screen now, but Actually its supposed to display 3d buildings QGroundControl as created in mapbox, but displaying only street view

bkueng commented 4 months ago

Also @bkueng @DonLakeFlyer this reminds me of something related to my recent QtLocationPlugin stuff. Previously only VWorld showed Bing as a back up if the API key was not entered or incorrect which seemed kinda misleading to me. Should I re-add that? Seems like there should either be no backup or a common one, otherwise the user has no idea what maps they are actually using.

Personally I would not add a backup with the argument that if the user wanted a custom map, it's confusing if some other map is shown. Or at least show an error message.

ashokbugude commented 4 months ago

Able to see after zooming in more