mavlink / qgroundcontrol

Cross-platform ground control station for drones (Android, iOS, Mac OS, Linux, Windows)

http://qgroundcontrol.io

3.22k stars 3.55k forks source link

QGC is unable to find SYS_HAS_NUM_ASPD parameter on PX4 (1.14.3) #11882

Closed trileis closed 1 week ago

trileis commented 2 weeks ago

Expected Behavior

No error displayed after firmware upgrade

Current Behavior

A SYS_HAS_NUM_ASPD missing parameter is thrown (see screenshot in reproducer)

Steps to Reproduce:

With "Fixed Wing" airbone,

Flash FC with latest firmware version (1.14.3):
Go back to summary and get a popup with the error:

System Information

Operating System: Windows10
QGC Version: 4.4.2/4.4.1
QGC build: stable
Flight Controller: Pixhawk 6X
Autopilot (with version): PX4 1.14.3

Detailed Description

Apparently the parameter SYS_HAS_NUM_ASPD is not present on the PX4 version 1.14.3, it should be merged in 1.15.0 (beta). In QGC code diff between version 4.4.0 -> 4.4.1 (here), this parameter is searched when PX4 version is upper or equal to 1.14. It should better be 1.15.

DonLakeFlyer commented 2 weeks ago

Fixed in daily builds

trileis commented 1 week ago

I don't see any modification on that part of code (PX4/SensorComponents.cc) on master since commit: da57ee. I think the problem still there on daily build.

DonLakeFlyer commented 1 week ago

I think the problem still there on daily build.

And you actually ran the daily build to verify that?

DonLakeFlyer commented 1 week ago

11425

trileis commented 1 week ago

Yes, I ran it two days before with the last master release. I think while PX4 doesn't release (at the moment) the parameter SYS_HAS_NUM_ASPD, this couldn't work. The SYS_HAS_NUM_ASPD parameter will be part of PX4 v1.15.0, which is at the moment in beta test.

To fix it, I downgrade QGC to 4.4.0 and it works like a charm with PX4 v1.4.3.

there's possibly a bug in #11425 or #11252. A fix could be to modify src/AutoPilotPlugins/PX4/SensorsComponent.cc to replace the check on PX4 version v1.14 by a check on v1.15.

I wish I have the time to do that as a dev but I'm trying to make my plane flying. I'm just playing with the Pixhawk system since a week so I'm not a dev for the moment.

DonLakeFlyer commented 1 week ago

there's possibly a bug

Yup, I'll fix it

DonLakeFlyer commented 1 week ago

Can you pull the build artifact from this pull once it's done and verify that it works for you?

trileis commented 1 week ago

Nice, I'll test that.

trileis commented 1 week ago

I tested the artifact from pull request (v4.3.0-889-gece5b6e55) and the problem is fixed. Thanks.

DonLakeFlyer commented 1 week ago

Great, thanks so much for testing. Sorry for screwing this up.