search

mavlink / qgroundcontrol

Cross-platform ground control station for drones (Android, iOS, Mac OS, Linux, Windows)
http://qgroundcontrol.io
3.07k stars 3.43k forks source link

Only allow GUI arming if home position has been provided by vehicle #3268

Closed LorenzMeier closed 8 years ago

LorenzMeier commented 8 years ago

Currently the UI allows to arm even if the home position not yet set. That's dangerous since the vehicle has no return position (or if the flight code is stupid, it will set the return position to somewhere in-air).

DonLakeFlyer commented 8 years ago

That's pretty vehicle/firmware specific based on flight modes and internal handling of whether the vehicle does anything interesting with home position or not. For example I'm not sure if something like ArduSub has that concept in it. QGC stays out of this level of detail. I would say it's up to the firmware to decide whether it should fail the arm as opposed to having QGC manage that.

julianoes commented 8 years ago

What about if arming just gets rejected by PX4 with a message? We could then add a parameter (circuit breaker?) to disable the behavior if you want to fly without position estimate.

LorenzMeier commented 8 years ago

I've done this since, we can close this.

julianoes commented 8 years ago

Awesome!