Make the ArduSub joystick function selector a plugin feature

mavlink / qgroundcontrol

Cross-platform ground control station for drones (Android, iOS, Mac OS, Linux, Windows)

http://qgroundcontrol.io

3.07k stars 3.43k forks source link

Make the ArduSub joystick function selector a plugin feature #3894

Closed rjehangir closed 7 years ago

rjehangir commented 7 years ago

Per Don's comments on PR #3879, there are a number of issues:

Joystick config is a global setting, so modifying the setup based on vehicle doesn't quite make sense
The if (sub) testing should be done more in a firmware plugin style. Like plugin->supportThrottleCenterZero of something like that.
A mechanism to expose the button ui in more generic way

rjehangir commented 7 years ago

These issues are addressed in PR #3896.

@DonLakeFlyer, I'm not 100% sure what you meant by "mechanism to expose the button ui in a more generic way", but I think I've accomplished that. To do this in firmware in ArduSub, we added a "AP_JSButton" library. The interface is now visible when the plugin supportsJSButton, which could be done on any vehicle type.

rjehangir commented 7 years ago

Changes have been pulled from #3896. Closing.