search

mavlink / qgroundcontrol

Cross-platform ground control station for drones (Android, iOS, Mac OS, Linux, Windows)
http://qgroundcontrol.io
3.3k stars 3.63k forks source link

Default component ID for PX4 incorrect (should be 0 for broadcast or 1 for param value, not 255) #5045

Closed LorenzMeier closed 7 years ago

LorenzMeier commented 7 years ago

@DonLakeFlyer This command is sent with system ID 1 (correct) and component ID 255 (why?)

sendMavCommand(FactSystem::defaultComponentId, MAV_CMD_DO_DIGICAM_CONTROL, true, // show errors 0.0, 0.0, 0.0, 0.0, // param 1-4 unused 1.0); // trigger camera
DonLakeFlyer commented 7 years ago

sendMavCommand(FactSystem::defaultComponentId

Bug. sendMavCommand isn't translating FactSystem::defaultComponentIdto actual default component id.

DonLakeFlyer commented 7 years ago

Fixed in here: https://github.com/mavlink/qgroundcontrol/pull/5048