mavlink / qgroundcontrol

Cross-platform ground control station for drones (Android, iOS, Mac OS, Linux, Windows)
http://qgroundcontrol.io
3.28k stars 3.6k forks source link

Feature request: Simplify "Action" button in Guided toolbar (Fly toolbar) #7354

Open Antiheavy opened 5 years ago

Antiheavy commented 5 years ago

The "Action" button usually only hides 1 action underneath (at most has 2 actions, one of which is "Change Altitude" which can be handled differently). This means the most likely "action" in any context is hidden from the user, requires unnecessary extra clicks, and isn't easily "discoverable" by new users. Most of our new users find it very confusing to find the actions under the Action button, especially when they accidentally dismiss the confirmation slider.

Request 1: Change the Fly toolbar to have a contextual button available depending upon the situation. The "Action" button already hides contextual sliders under it, can we replace the Action button itself with contextual buttons that display the appropriate slider?

Request 2: An important related request is to eliminate the "Change Altitude" action button and replace it with an always shown right-hand altitude slider when in Hold/Pause mode. This ensures there is only ever 1 "contextual" button.

See the following concept graphics: image

@DonLakeFlyer suggested I post this here for discussion with @dogmaphobic and others working on QGC UI.

Antiheavy commented 5 years ago

Related to "Request 2": There are other reasons I think Change Altitude slider should always be shown when in Hold/Pause mode. For example, you have the ability to move in X-Y by clicking around on the map and confirming, you should also have the ability to change altitude at this UI level without needing to discover it under a buried menu.

Somewhat related discussions: mavlink/qgroundcontrol#5826 mavlink/qgroundcontrol#5748 mavlink/qgroundcontrol#6721 mavlink/qgroundcontrol#5795

Antiheavy commented 5 years ago

@dogmaphobic or @DonLakeFlyer , any other thoughts on this proposal to simplify the "Action" button behavior?

DonLakeFlyer commented 5 years ago

Ok so the possible actions which can show up under "Action" are:

Reason for the Action button:

The only case for multiple actions appropriate at the same time are in combination with Change Altitude. It's think it's doable to show this automatically if the vehicle is "Paused". But it would require the confirmation to move to be within that alt ui as opposed to using the Action slider. Since you shouldn't be able to dismiss it without a way to get it back. All doable.

With that change then I believe you are only left with mutually exclusive commands which could be displayed as the last button. Which would only then be needed if you closed the contextual slider when it popped up and wanted it back.

Unlikely to get to this before I head out of town again. But I'll start on it when I get back. Quite complex change so will need to happen on master.

Antiheavy commented 5 years ago

Since you shouldn't be able to dismiss it without a way to get it back.

If you drag the change altitude column up or down, the confirmation slider should automatically appear at the bottom of the screen. If you dismiss the confirmation slider then whatever change you made on the change altitude column should revert. To bring back the confirmation slider you'd have to make another change on the change altitude column with which needs confirming.

Unlikely to get to this before I head out

no problem. Users aren't screaming for it, but in general hiding things under the "Action" button is a point of confusion and mystery to them. Putting more functionality right at the top level UI makes things more discoverable and intuitive.

DonLakeFlyer commented 5 years ago

Awesome way to handle the change alt confirm. I'll do that.

dakejahl commented 3 years ago

Any updates here? If I started working to implement these changes, would I be stepping on anyone's toes?

DonLakeFlyer commented 3 years ago

Any updates here?

Nope. Still seems like a reasonable thing to do.

Antiheavy commented 3 years ago

If I started working to implement these changes, would I be stepping on anyone's toes?

@dakejahl let's give it a try!