search

mavlink / qgroundcontrol

Cross-platform ground control station for drones (Android, iOS, Mac OS, Linux, Windows)
http://qgroundcontrol.io
3.23k stars 3.57k forks source link

Yes/No buttons reversed from common convention in "are you sure you want to close" pop-up #7679

Closed Antiheavy closed 4 years ago

Antiheavy commented 5 years ago

The Yes and No buttons in this pop-up are reversed from common convention: image

Suggest Yes on the left and No on the right.

Google image search is a wonderful reference tool: https://www.google.com/search?client=firefox-b-1-d&channel=tus&biw=1278&bih=964&tbm=isch&sa=1&ei=XWxTXZPjHfLrtQaj6L0g&q=no+%2F+yes+popup&oq=no+%2F+yes+popup&gs_l=img.3..0i8i30.23103.24829..25664...0.0..0.73.516.8......0....1..gws-wiz-img.......0i7i30j0i67j0i7i5i30j0i5i30j0i24j0i8i7i30.FukPWV0VTsw&ved=0ahUKEwjThZaCo4HkAhXydc0KHSN0DwQQ4dUDCAY&uact=5

DonLakeFlyer commented 5 years ago

@dogmaphobic Some strangeness from the conversion to message boxes?

dogmaphobic commented 5 years ago

This is Qt's own message dialog. They determine the order of the buttons. Even the documentation shows a negative before the positive:

qtlabsplatform-messagedialog-informative-android

https://doc.qt.io/qt-5/qml-qt-labs-platform-messagedialog.html

DonLakeFlyer commented 5 years ago

Ick, that order is correct for OSX but incorrect for Windows.

DonLakeFlyer commented 5 years ago

Which means Qt bug

Antiheavy commented 5 years ago

The same warning popup is Positive then Negative in the Stable release of QGC (I'm using Windows): image

dogmaphobic commented 5 years ago

They use different versions of Qt.

DonLakeFlyer commented 5 years ago

Stable and Daily windows use the same version of Qt. Different version of Import between Stable/Daily? Maybe go back one (or whatever) to what Stable is using? Or maybe a QGCMessageDialog which isolates the import version usage?

dogmaphobic commented 5 years ago

Sorry, QtQuick 1.x versus QtQuick 2.x.

DonLakeFlyer commented 5 years ago

I'm not sure about that. MessageDialog (https://doc.qt.io/qt-5/qml-qtquick-dialogs-messagedialog.html) is import QtQuick.Dialogs 1.3 which isn't part of the 2.0 stuff. Stable uses 1.3, Daily uses 1.2. I bet it's just broken in 1.3.

dogmaphobic commented 5 years ago

I tested a few variations and realized it makes no difference on macOS. Testing on something else is not that simple right now...

DonLakeFlyer commented 5 years ago

Import 1.2/1.3 make no difference on Windows.

Antiheavy commented 4 years ago

This seems resolved in the latest daily builds that are using newer version of Qt. I think I can close this. image