mavlink / qgroundcontrol

Cross-platform ground control station for drones (Android, iOS, Mac OS, Linux, Windows)
http://qgroundcontrol.io
3.22k stars 3.55k forks source link

Feature Request: QGC checks mission against vehicle parameters for feasibility #7836

Open Antiheavy opened 5 years ago

Antiheavy commented 5 years ago

One of the most common user complaints about QGC is the lack of feedback to the user when planning a mission (in the top 3 user complaints for us).

PX4 has an onboard "mission feasibility checker" that checks the mission AFTER it has been uploaded. This is a nice safety feature for the vehicle, but is very frustrating to users who spent a bunch of time planning a mission only to have it rejected with cryptic warning messages back from the autopilot as to why.

It seems to me that QGC has a lot of information in the downloaded parameters about if the vehicle will reject the mission or not. This list may not be complete, but here are a the most common/problematic PX4 parameters that could be checked against the mission live while planning: GF_MAX_HOR_DIST GF_MAX_VER_DIST MIS_DIST_1WP MIS_DIST_WPS FW_LND_ANG MIS_TAKEOFF_REQ RTL_TYPE (to see if a landing sequence is required)

Proposed approach:

PX4 feasibility checker: https://github.com/PX4/Firmware/blob/master/src/modules/navigator/mission_feasibility_checker.cpp

Antiheavy commented 5 years ago

fyi @dagar @DonLakeFlyer

hamishwillee commented 5 years ago

That sounds cool.

@Antiheavy - is there also a PR in place in PX4 to provide less cryptic upload fail messages. Working the problem at both ends makes sense.