mavlink / qgroundcontrol

Cross-platform ground control station for drones (Android, iOS, Mac OS, Linux, Windows)
http://qgroundcontrol.io
3.19k stars 3.53k forks source link

Cannot connect multiple vehicles over serial communication #9060

Open dhruv-mehta99 opened 4 years ago

dhruv-mehta99 commented 4 years ago

The following template is for Issue/Bug reporting only. https://docs.qgroundcontrol.com/en/Support/Support.html#github-issues

Current Behavior

the error is when I try to connect more than one vehicle to QGC then the software only reads data over serial communication from 1 vehicle only (the vehicle which is connected 1st) and doesn't read data from 2nd vehicle (though vehicle connects to the QGC, but the software doesn't read data from that com port(COM3 in my case).

Steps to Reproduce:

Please provide an unambiguous set of steps to reproduce the current behavior

  1. connect any 1 vehicle via serial communication.
  2. now connect 2nd vehicle over serial communication.
  3. the 2nd vehicle won't show up on the screen but it would make the software misbehave.

System Information

When posting bug reports, include the following information

Detailed Description

the readBytes function in SerialLink.cc file is not called to read data from COM3 ( as a result of which 2nd vehicle heartbeat is not received by the multivehicle manager and so the multivehicle mode UI is not activated in frontend). as a result of this whole situation, the software misbehaves when more then 1 vehicle is connected via serial communication.

Though when I connect these vehicles individually on the same ports(COM4 and COM3) they work fine.

DonLakeFlyer commented 3 years ago

The code for de-duping composite USB devices is screwed up.

DonLakeFlyer commented 3 years ago

@dhruv-mehta99 There should be new daily builds in about an hour. Can you verify the fix?