Open hamishwillee opened 2 years ago
Thanks @hamishwillee for this explanation. So I'm a little confused by the workaround for this.
Is this something that gets fixed fast or should we fix the documentation to note this?
Who knows. I think we wait on @DonLakeFlyer to tell us. Though if @julianoes was working on this for some particular job it might come earlier.
~For me that's fixed with https://github.com/PX4/PX4-SITL_gazebo/pull/801. QGC then crashes after a bit but that's going to be another issue.~
Edit: now that I read the issue I can see that there is more.
QGC should automatically set up and display "a" video stream for a vehicle that supports the MAVLink Camera API. It appears to correctly select the correct video source but does not display it.
Tested using the PX4 Gazebo Typhoon simulation running on Ubuntu 20.04 (in a VM) against the current release QGC.
Expected Behavior
When QGC connects to a vehicle that supports the MAVLink Camera API it can tell what video streams it supports. These should be used to configure the application video settings such that the video streams appears in the fly view video widget (irrespective of current video settings).
Because you have auto-configured video streams, the video settings in Application Settings > General Settings > Fly View should not be displayed when you are connected to a vehicle that supplies this information.
Current Behavior
So QGC is switching to the right setting, but doesn't seem to be able to then start viewing the stream.
The fact that this is broken is particularly bad, because it means that if your initial setting is wrong, you can't even go back and fix it.
Steps to Reproduce:
Video streaming set up exactly as described in PX4 user guide: https://docs.px4.io/master/en/simulation/gazebo.html#video-streaming PX4 using latest version of master. All on Ubuntu 20.04
Only tested for this scenario - so maybe it would switch correctly for some other system
System Information
When posting bug reports, include the following information
Log Files and Screenshots
Here I set QGC video source to Parrot Discovery (incorrect)![image](https://user-images.githubusercontent.com/5368500/133382781-bb72ab05-782f-4f36-96e7-1aeedf69814e.png)
This is the screenshot of QGC video widget when when I start simulation. Streaming is happening, but not Parrot format:
Here I disconnect the vehicle, and go back to the settings. Note, they have changed to be correct!![image](https://user-images.githubusercontent.com/5368500/133383029-b2faa8d5-f3e7-4b1b-bfea-5f2442b6dfb5.png)
If I run again, then the video displays correctly