mavlink / rust-mavlink

MAVLink library for Rust.
https://mavlink.github.io/rust-mavlink/mavlink/
Apache License 2.0
158 stars 79 forks source link

align MSRV check with 'rust-version' #200

Closed danieleades closed 1 year ago

danieleades commented 1 year ago

the MSRV check should match the 'rust-version' specified in Cargo.toml

danieleades commented 1 year ago

as you can see from the failed test, the rust-version in Cargo.toml is not correct. I'll have to bump the version to get this to build

danieleades commented 1 year ago

i've left the commits in there for ease of review, but you probably want to squash merge this

patrickelectric commented 1 year ago

Thanks @danieleades, can you squash the commits ? We don't have squash merge enable for better descriptive commit messages.

danieleades commented 1 year ago

Thanks @danieleades, can you squash the commits ? We don't have squash merge enable for better descriptive commit messages.

What is the impact on commit messages of using github's squash merge? It gives you the option of setting the commit message when you merge, no?