Open danieleades opened 2 months ago
Should also consider setting a custom default rust-analyzer command that doesn't emit every single target
To also improve the documentation using #![feature(doc_auto_cfg)]
to add those "Available on crate feature featurename only." badges would be a good idea.
Apparently this is a nightly feature but docs.rs is on nightly so #![cfg_attr(docsrs, feature(doc_auto_cfg))]
would work.
@patrickelectric can you provide any context on what combinations of features are allowed?
This was probably broken on the pass PRs, some work need to be done to fix that besides adding tests in CI.
This was probably broken on the pass PRs, some work need to be done to fix that besides adding tests in CI.
I guess i'm trying to understand what is expected to work
This was probably broken on the pass PRs, some work need to be done to fix that besides adding tests in CI.
I guess i'm trying to understand what is expected to work
At the moment, check the combinations in CI. For conflict configuration is still necessary to document.
Would be great to have some documentation on valid combinations of features. This repo makes heavy use of features and some of these are mutually exclusive or have other relationships between them.
These should be documented and invalid combinations should have clear panic messages.
Would also be good to review that all of the valid combinations are tested in CI
i note that
Cargo.toml
contains these comments:additionally, the following feature combinations fail to compile (not exhaustive):
--no-default-features
--no-default-features --features std
--no-default-features --features ardupilotmega
the following combinations do compile (not exhaustive):
--no-default-features --features std,ardupilotmega