mavlink / rust-mavlink

MAVLink library for Rust.
https://mavlink.github.io/rust-mavlink/mavlink/
Apache License 2.0
157 stars 78 forks source link

compilation warnings due to missing `storm32` feature #264

Open danieleades opened 2 months ago

danieleades commented 2 months ago

There are compilation warnings on master due to missing storm32 feature.

The code-gen generates a storm32 cfg attribute, since this dialect is described in the mavlink message definitions, however Cargo.toml contains no such feature.

The warning should be addressed or suppressed.

warning: `mavlink-core` (lib) generated 1 warning
   Compiling mavlink v0.13.2 (/home/dan/Code/rust/rust-mavlink/mavlink)
warning: `mavlink-core` (lib test) generated 1 warning (1 duplicate)
warning: unexpected `cfg` condition value: `storm32`
 --> /home/dan/Code/rust/rust-mavlink/target/debug/build/mavlink-60b3f9a616716175/out/mod.rs:1:1960
  |
1 | ...:: unnecessary_cast)] # [allow (clippy :: bad_bit_mask)] # [cfg (feature = "storm32")] pub mod storm32 ; # [allow (non_camel_case_types)] # [allow (cl...
  |                                                                     ^^^^^^^^^^^^^^^^^^^
  |
  = note: expected values for `feature` are: `all`, `all-dialects`, `ardupilotmega`, `asluav`, `avssuas`, `common`, `cubepilot`, `default`, `development`, `direct-serial`, `embedded`, `embedded-hal-02`, `emit-description`, `emit-extensions`, `format-generated-code`, `icarous`, `matrixpilot`, `minimal`, `paparazzi`, `python_array_test`, `serde`, `slugs`, `standard`, `std`, `tcp`, `test`, `tokio-1`, `ualberta`, `uavionix`, and `udp`
  = help: consider adding `storm32` as a feature in `Cargo.toml`
  = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
  = note: `#[warn(unexpected_cfgs)]` on by default
pv42 commented 2 months ago

165 I think there is an issue with that dialect, thats why it is not included, so supressing would probably be a better solution.

pv42 commented 2 months ago

Looking further into it it seems like the problem is solved/deemded to be not a problem so maybe just adding the feature would actually be better.