mavlink / rust-mavlink

MAVLink library for Rust.
https://mavlink.github.io/rust-mavlink/mavlink/
Apache License 2.0
158 stars 79 forks source link

Test with no-dev-deps all-targets #277

Closed pv42 closed 2 months ago

pv42 commented 2 months ago

The MSRV check tests run cargo no-dev-deps check --all --all-targets [features] this appears to me as a mistake since no-dev-deps disables dev dependencies but --all-targets includes test which (might) need dev dependencies. This was changed recently by @danieleades in a729400 so I was wondering if there is a reason for it that I am missing or if is just a mistake. If so it can by fixed by changing the check to either cargo check --all --all-targets [features] or split commands for targets that need dev-deps:

danieleades commented 2 months ago

Yeah I suspect --all-targets can be removed