search

mavlink / rust-mavlink

MAVLink library for Rust.
https://mavlink.github.io/rust-mavlink/mavlink/
Apache License 2.0
157 stars 78 forks source link

Don't support signing? #82

Open hamishwillee opened 3 years ago

hamishwillee commented 3 years ago

Just confirming for the mavlink docs tat this library doesn't support signing - right?

Are there any more docs than provided on the readme? For context, I'm trying to characterize the things provided by each project

patrickelectric commented 3 years ago

Hi @hamishwillee, I hope that you are doing fine.

About rust-mavlink, it indeed has a support for signed messages, but not fully. It can receive but will do nothing with the signed value itself.

For documentation, you can get it here: https://docs.rs/mavlink/latest/mavlink/ For testing: https://github.com/mavlink/rust-mavlink/tree/master/tests

hamishwillee commented 3 years ago

Thank you very much for the clarification.

hamishwillee commented 3 years ago

Note, I've updated mavlink docs with link in https://github.com/mavlink/mavlink-devguide/pull/312

I have not updated the information on signing because it still isn't quite clear to me what you mean by not supported. Full signing support would look something like:

  1. Has a mechanism for setting a key to use for signing messages (key management itself might be in hardware).
  2. Has mechanism for turning signing on and off
  3. If signing turned on will sign MAVLink 2 messages.
  4. If signing not turned on will parse signed and unsigned messages
  5. If signing turned on will reject unsigned messages by default, but has hooks to allow an implementation to choose to keep some messages.

Assuming we're aligned on the above can you confirm again which it does/does not do?