mavlink / rust-mavlink

MAVLink library for Rust.
https://mavlink.github.io/rust-mavlink/mavlink/
Apache License 2.0
158 stars 79 forks source link

Add deployment to crates.io #85

Closed mrpollo closed 3 years ago

mrpollo commented 3 years ago

It would be awesome if we could have the package in crates.io

This was originally brought up by @patrickelectric on the PX4 Slack #mavlink channel

This is an isssue to track.

patrickelectric commented 3 years ago

Hi @mrpollo, sorry if I was not clear. We have the package under https://crates.io/crates/mavlink, in the pass the update was done manually, after some work we turn it to be automatic done by travis, and not we moved from travis to github actions. So, with that change we need to add the secret key on the repository to be able to do the automatic package update on crates.io. Since I don't have permission to do such thing it's necessary to someone that has access to crates.io to add the key.

kevinmehall commented 3 years ago

@podhrmic set this up before. There's a rust-mavlink-builder account on GitHub / crates.io whose crates.io API key was added as a secret in the Travis config for automatic publishing.

podhrmic commented 3 years ago

Correct. @kevinmehall do you need me to change anything about the builder account, or can you just copy the API key to github actions?

patrickelectric commented 3 years ago

I believe that only the API key on the repository secrets should be enough

mrpollo commented 3 years ago

@podhrmic @kevinmehall can the secret be copy-pasted directly from the Travis config? or should we re-generate the secret?

I went ahead with the copy/paste route and added the secret, as a "Repository Secret"

See screenshot 👇

Screen Shot 2021-03-08 at 1 30 36 PM
kevinmehall commented 3 years ago

The value is encrypted in the .travis.yml and I don't think Travis offers a way to get it in cleartext, so @podhrmic will need to generate a new token and add it on GitHub's repository secrets.

kevinmehall commented 3 years ago

I increased your permissions so you can get to the repository secrets

podhrmic commented 3 years ago

Token updated. It should be working now. How can we test it?

patrickelectric commented 3 years ago

I'll soon create the build step for crates.io deployment

patrickelectric commented 3 years ago

Done: https://github.com/mavlink/rust-mavlink/pull/92

mrpollo commented 3 years ago

Thanks everyone 👏