search

mavoweb / plugins

Teach Mavo new tricks!
https://plugins.mavo.io
7 stars 36 forks source link

Use Primitive#upload instead of copy/paste its code #71

Closed DmitrySharabin closed 3 years ago

DmitrySharabin commented 4 years ago

I just want to say that it's OK if we won't merge this PR since it has to deal with some aspects of properties, like an attribute and a property value (see the comments in the code).

If we decide to leave the previously merged version, it might be a good idea to use line 121 from this PR and send a separate PR with it. What do you think?

DmitrySharabin commented 3 years ago

@LeaVerou Hey Lea! 👋🏻 Will you please have a look at this PR? I have an open Gestalt because ot it. :)

LeaVerou commented 3 years ago

Also, do note that simply replacing the entire text drops your undo stack. There are workarounds, but not for all browsers.

See

https://stackoverflow.com/questions/19814465/is-it-possible-to-insert-text-in-textarea-and-update-undo-redo-queuehttps://stackoverflow.com/questions/44471699/how-to-make-undo-work-in-an-html-textarea-after-setting-the-value

and many others

DmitrySharabin commented 3 years ago

Thank you, Lea, for all your comments. I learn a lot from you. I'll work through them and will make some improvements.

DmitrySharabin commented 3 years ago

As I mentioned in #76, I'm going to close this PR with a pure heart. I learned a lot from it. :)