search

mavoweb / treecle

WIP. A toolbox for hierarchical JS objects.
https://treecle.mavo.io
MIT License
6 stars 0 forks source link

`children` does not check whether returned nodes are nodes #17

Open adamjanicki2 opened 6 months ago

adamjanicki2 commented 6 months ago

The children function needs to use the isNode function from the context to check whether nodes are actually nodes

LeaVerou commented 6 months ago

I believe it doesn't do that only when following getChildProperties() (or what replaces it) as a perf optimization, the assumption being that then it's on the author to supply correct information. That said, it should check that they are truthy.