search

mavoweb / treecle

WIP. A toolbox for hierarchical JS objects.
https://treecle.mavo.io
MIT License
6 stars 0 forks source link

`assertParentPointers` function #29

Closed adamjanicki2 closed 5 months ago

adamjanicki2 commented 6 months ago

closes #26

netlify[bot] commented 6 months ago

Deploy Preview for treecle ready!

Name Link
Latest commit 74c9b865eaca07c007a2027b10d7f5289fa134af
Latest deploy log https://app.netlify.com/sites/treecle/deploys/660439642db705000888dde1
Deploy Preview https://deploy-preview-29--treecle.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

LeaVerou commented 5 months ago

Also, if we don't implement warn yet, let's drop it from the API. There's no reason to have it.

adamjanicki2 commented 5 months ago

LGTM. Minor comment, but I'd change the function name, checkParentPointers() sounds like a function that checks if they exist and returns a boolean, not something that will produce an error.

Good point, just switched it to assertParentPointers

adamjanicki2 commented 5 months ago

Also, if we don't implement warn yet, let's drop it from the API. There's no reason to have it.

Sounds good!