mawaqit / android-tv-app

Prayer times App for Android TV
https://mawaqit.net
Other
38 stars 17 forks source link

fix: The pictures in announcements are not fitting the screen #1096

Closed YassinNouh21 closed 6 months ago

YassinNouh21 commented 6 months ago

πŸ“ Summary

This PR fixes #1019

Description

Currently, the pictures in announcements are not properly fitting the screen, especially on tablets, leaving small margins at the top and bottom. This issue affects the visual presentation and user experience of the announcement screen.

To address this issue, the following changes have been made:

  1. In the AnnouncementScreen.dart file, the fit property of the Image widget has been changed from BoxFit.fitWidth to BoxFit.fill.
  2. The BoxFit.fill value ensures that the image fills the entire available space of the widget, both horizontally and vertically, while maintaining its aspect ratio.

By making this change, the pictures in announcements will now properly fit the screen, eliminating the small margins at the top and bottom, resulting in an improved visual presentation.

Tests

πŸ§ͺ Use case 1

πŸ’¬ Description:

  1. Launch the app on a tablet device.
  2. Navigate to the announcement screen.
  3. Verify that the picture in the announcement fills the entire screen, without any visible margins at the top or bottom.

πŸ“· Screenshots or GIFs (if applicable):

image

Checklist: