maward-sci / c_scenarios

1 stars 0 forks source link

Cdd/model qa #13

Closed cdibble closed 1 year ago

cdibble commented 1 year ago

This PR:

Fixes a few mistakes in model components after reviewing the logic
Adds a bit of code commentary

To Do

[ ] Check whether the negative value is actually appropriate in Biomass:Conservation:BAU spec.
[ ] Double check the Area calculations -- this dataframe has not yet been through a thorough validation
[ ] Review plots to ensure that the model specification is correct
[ ] Update README model spec to ensure that the equations are correct and the nomenclature is what we want.