Closed markx86 closed 9 months ago
Thank you very much for your contribution. That's quite a patch. Can you write a sentence or two about the non-obvious changes, like moving the oauth stuff and introducing the mainloop? The imports are mostly syntactic stuff, I guess.
Hi, my bad, was pretty big... Sorry :)
I split it up in multiple commits, hopefully that's easier to go through.
I'd say the main changes are due to the fact that extensionUtils.getCurrentExtension()
does not exist anymore and should be replaced by ExtensionBase.lookupByUUID()
or ExtensionBase.lookupByURL()
, but I couldn't get those to work.
To solve all the issues related to that, I had to add some arguments to the constructors of the App
class, in prefs.js
, and the ExtensionLayout
class, in extension.js
. I realize that this is not the most elegant solution, but I'm not a JavaScript developer, so if anybody has a better idea, please feel free to implement it.
As per mainloop.js
, that wasn't necessary, I just mistyped imports
and assumed it was removed when it threw an error. That file has now been removed.
but I'm not a JavaScript developer
That's not the only issue with gnome shell development. Thank you very much for wading through that cesspool.
Port the extension to GNOME 45.