search

maweki / twitchlive-extension

TwitchLive-Panel Gnome Shell Extension displaying your favorite streamers
GNU General Public License v3.0
39 stars 8 forks source link

Streamer notifications #47

Closed ghost closed 6 years ago

ghost commented 6 years ago

Notifications and settings (off by default) for:

Areas for improvement:

Closes #38.

maweki commented 6 years ago

First of all, thank you for your contribution. Working with gnome/gtk and especially the shell is very frustrating. Not only is it a moving target. It is an undocumented mess of a moving target without a care in the world for usability and actual workflows, which is why I no longer am member of the gnome foundation and no longer contribute code or time. Which shouldn't discourage you at all O:-)

At first glance the code looks fine. I have to test it though. Did you look what happens when you come back from (non-locking) hibernation?

Making it focus the stream if it's already open (eg. game changes). That seems difficult.

This seems quite hard since we give the ability for custom executables. VLC with my settings would always launch a new instance.

ghost commented 6 years ago

Which shouldn't discourage you at all O:-)

Your frustrations have not discouraged me, but mine have ;p

Did you look what happens when you come back from (non-locking) hibernation?

It shows notifications for $current - $suspend. Configurations (which I've tried) using the lock screen seem to start fresh.

This seems quite hard since we give the ability for custom executables.

I realize, now, that this applies in a more general scope than I intended. I don't know of anything useful for this; so I wasn't intending to suggest that be solved.

Translations, though! I'm not able to make xgettext play nice, sooo hardcoded strings are a thing. Sorry.

maweki commented 6 years ago

I can test this now. Will take me a few days from here, I guess.

maweki commented 6 years ago

I think this PR is now fine. I'll merge it (maybe ff) and do a release soon. Since I am still e.g.o moderator I think my extensions skip the queue. If not, there are about two hundred extensions waiting in line.

ghost commented 6 years ago

I'm going to delete this github account, which will remove this pull request (according to the warning text). If you would, please merge this to a feature branch if you want to keep the code and do not want it in master.