search

maweki / twitchlive-extension

TwitchLive-Panel Gnome Shell Extension displaying your favorite streamers
GNU General Public License v3.0
38 stars 8 forks source link

Updated to new Twitch API #56

Closed zikeji closed 5 years ago

zikeji commented 5 years ago

I definitely couldn't have this beautiful extension not working for me! I've manually updated it to support the Helix API, as well as adding chunking for greater than 100 logins / ids / etc.

Everything is working as far as I can tell - Twitch follow import, icon download, updating active streams, etc. However I didn't take the time to begin to grasp the inner workings of this extension nor have I ever worked on a Gnome extension before (debugging was a PITA!).

I've left some comments for review by the maintainer. These changes get the extension working, however.

maweki commented 5 years ago

This looks good and is a starting point for the next work. I will merge and publish it in the next few hours and will then be offline until sunday.

I think we need to cache the game data requests. We don't use any dynamic game data (like how many people are currently watching a specific game) so ideally we would only trigger requests when we encounter a game for the first time this session.