maweki / twitchlive-extension

TwitchLive-Panel Gnome Shell Extension displaying your favorite streamers
GNU General Public License v3.0
38 stars 8 forks source link

Settings doesnt' work in GNOME 40 (needs to be gtk4) #75

Closed maweki closed 3 years ago

maweki commented 3 years ago

I don't know what the f*** they broke again. If anybody has a hint or an error message, it would be appreciated.

maweki commented 3 years ago

So they added the version-check again. Great. If only you could actually then check which version you're running under...

This is the error message then

TypeError: Gtk.IconTheme.get_default is not a function

Stack trace:
  init_icons@/home/maweki/.local/share/gnome-shell/extensions/TwitchLive_Panel@extensions.maweki.de/icons.js:19:17
  App@/home/maweki/.local/share/gnome-shell/extensions/TwitchLive_Panel@extensions.maweki.de/prefs.js:33:11
  buildPrefsWidget@/home/maweki/.local/share/gnome-shell/extensions/TwitchLive_Panel@extensions.maweki.de/prefs.js:235:18
  _init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:209:40
  OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
  asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:115:22
  run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20
  main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
  run@resource:///org/gnome/gjs/modules/script/package.js:206:19
  start@resource:///org/gnome/gjs/modules/script/package.js:190:8
  @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

But guess what? If you put imports.gi.Gtk.IconTheme.get_default into looking glass, you get <js function>

maweki commented 3 years ago

Okay, so you need to add "40" not "3.40". And then it all works again. And the error message is from years ago. But the Settings dialogue is broken, as it needs to be gtk4

maweki commented 3 years ago

Also, I can't upload anything or even read documentation because most of gnome.org is offline. Do I sound pissed?

maweki commented 3 years ago

I think we may need a BuilderScope. But hell if I know https://gjs.guide/extensions/upgrading/gnome-shell-40.html#gtkbuilder

maweki commented 3 years ago

works now