search

maweki / twitchlive-extension

TwitchLive-Panel Gnome Shell Extension displaying your favorite streamers
GNU General Public License v3.0
38 stars 8 forks source link

Add support for GNOME 43 #92

Closed Nibbler999 closed 1 year ago

Nibbler999 commented 1 year ago

Add compatibility with libsoup 3.0 which is the default now. Tested on Fedora 37 Beta.

maweki commented 1 year ago

That's great. Can you take a look at #90 and its resolution? Maybe it's good to fix the import version. And I guess it's better if that's the same both for the panel process and the settings process. What do you think?

Nibbler999 commented 1 year ago

My understanding is that you can't use both libsoup2 and libsoup3 in the same process. gnome-shell in GNOME 43 uses libsoup3 so the extension has to support it as it's running in the same process. Using libsoup2 in the prefs process is fine for now, but it will be removed fairly soon so supporting libsoup3 is the way forward.

maweki commented 1 year ago

Can we just support 43 (the older extension releases will be available for the older she'll versions) and just go with the libsoup3 code on both the panel and the settings?

Nibbler999 commented 1 year ago

OK, PR updated according.

maweki commented 1 year ago

That looks good. I'll do a release over the next few days. Thank you.

maweki commented 1 year ago

Also, please add yourself to the authors list where appropriate on your next contribution :)