maweki / twitchlive-extension

TwitchLive-Panel Gnome Shell Extension displaying your favorite streamers
GNU General Public License v3.0
38 stars 8 forks source link

Added Streamer Icon to Notifications #93

Closed ghost closed 1 year ago

ghost commented 1 year ago

Tested on Gnome 42.

Before: image

After: image

ghost commented 1 year ago

Added "Show streamer icon on notifications" to the settings panel.

image

ghost commented 1 year ago

By default, the "Show streamer icon on notifications" setting is disabled, so I've made livestreamer-icons/twitchlive.svg the default icon.

Disabled: image

Enabled: image

maweki commented 1 year ago

First of all, thank you for your contribution. Looks good to me. As a heads up: I will squash all those commits and the next release (and all future ones) will be targeting gnome 43 only/and later. So I won't do a release with this feature for 42 or earlier. Hope that's fine.

ghost commented 1 year ago

That's fine. Thank you for a perfect extension! :smile:

maweki commented 1 year ago

Really cool would be if the new option was disabled if neither of the notification options are enabled.

ghost commented 1 year ago

Demo.webm

maweki commented 1 year ago

Oh no, you should never change the flow of the UI. The elements should be disabled (greyed out) so that they are unusable if they have no effect.

Sorry for the miscommunication.

ghost commented 1 year ago

Demo.webm

maweki commented 1 year ago

I think that looks quite good. Just give me a heads up that you're also done and happy and I'll do the merge.

ghost commented 1 year ago

I'm ready for the changes to be merged.