Closed ghost closed 1 year ago
Added "Show streamer icon on notifications" to the settings panel.
By default, the "Show streamer icon on notifications" setting is disabled, so I've made livestreamer-icons/twitchlive.svg the default icon.
Disabled:
Enabled:
First of all, thank you for your contribution. Looks good to me. As a heads up: I will squash all those commits and the next release (and all future ones) will be targeting gnome 43 only/and later. So I won't do a release with this feature for 42 or earlier. Hope that's fine.
That's fine. Thank you for a perfect extension! :smile:
Really cool would be if the new option was disabled if neither of the notification options are enabled.
Oh no, you should never change the flow of the UI. The elements should be disabled (greyed out) so that they are unusable if they have no effect.
Sorry for the miscommunication.
I think that looks quite good. Just give me a heads up that you're also done and happy and I'll do the merge.
I'm ready for the changes to be merged.
Tested on Gnome 42.
Before:![image](https://user-images.githubusercontent.com/101745538/192156247-9f72fc3f-77fa-44b2-821c-4d95547696c7.png)
After:![image](https://user-images.githubusercontent.com/101745538/192156305-d1ce2c81-3b3b-4324-b856-02a321c49564.png)