search

mawie81 / electron-oauth2

A library to handle OAuth2 authentication for your Electron app.
MIT License
99 stars 56 forks source link

Fix Grant Code retrieval #30

Closed vinmean closed 6 years ago

vinmean commented 6 years ago

The original code does not work in the case of brokered OIDC as it just looks for the grant code to show up as url param in one of the redirects. In the brokered OIDC scenario the broker can have a temporary code show up in the middle of the flow. e.g. if I setup a identity broker flow in Keycloak, keycloak uses a temporary code before the actual auth happens with configured OIDC IDP. In such a case, wrong code is used to request token

In this enhancement, code is retrieved only when the redirect url is corresponding to the redirect uri configured. This would work in both single IDP and brokered IDP scenario

In addition, login event handler has been added for cases where browser would have shown http basic auth popup instead of login page. This occurs in the case of brokered OIDC where Windows Integrated Authentication is triggered.

vinmean commented 6 years ago

Hmmm! Seems like the git commits are screwed up somehow. Will fork again