mawie81 / electron-oauth2

A library to handle OAuth2 authentication for your Electron app.
MIT License
99 stars 56 forks source link

Opening in same BrowserWindow #32

Open aguynamedben opened 6 years ago

aguynamedben commented 6 years ago

Hi, thank you for this excellent library. It helped me a ton. It's a great reference for how to do OAuth2 in Electron, and it works out of the box without any issues. I have it working very well with jsforce.

I was wondering if you had considered an option that would allow the current BrowserWindow to be used for OAuth2 sign in. Is there a fundamental reason that wouldn't work? A lot of users find the alwaysOnTop option of the new BrowserWindow annoying, especially if they use a password manager to store passwords or need to Cmd-Tab over to Messages to get a 2FA code).

I'd be interested in doing the work to support same-window OAuth2 if you could point me in the right direction. Thanks a lot again for this great library.