mawie81 / electron-oauth2

A library to handle OAuth2 authentication for your Electron app.
MIT License
99 stars 56 forks source link

Added Optional Redirect URI for OAuth Clients that require specific Redirect URIs #7

Closed DeekyJay closed 8 years ago

DeekyJay commented 8 years ago

Jumped the gun too soon, I will have more changes.

mawie81 commented 8 years ago

Thanks for the PR 👍 Before looking at this could you please check the parameter name again? The readme says redirectUri but the code uses redirect_uri. Would prefer redirectUri for the option.

And could you please stash the commits into one?

Thanks 😄

DeekyJay commented 8 years ago

Hey! Fixed the issue and rebased. Not sure why there is a conflict though.

mawie81 commented 8 years ago

Thanks 😄 Just landed and published as 2.2.0

DeekyJay commented 8 years ago

Awesome! :smile: