vercel[bot]
commented
2 years ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| spades-calculator | ✅ Ready (Inspect) | Visit Preview | Jun 6, 2022 at 7:58PM (UTC) |
Okay soooooo I accidentally checked out hte main branch instead of the sessionStorage_bug branch. I didn't really do a whoel lot of testing but it seemed to be working as expected. To be honest I don't know how to play spades.
But I just added a check to make sure we weren't trying to add rounds to the round history if we shouldn't be doing that.
Honestly, though, if this were my app, I'd move all of the game logic and state management to the SpadesCalculator component and instead of having one SpadesRound component I'd have two separate components, one for rendering an active board and another for those that are in the past. The old boards really don't seem to need interaction at all and it seems unnecessary to have all that logic being run even for inactive boards.