mawinkler / astroweather

Asynchronous Astro Weather Forecast for Home Assistant
GNU General Public License v3.0
79 stars 9 forks source link

Temperature and dewpoint are celsius only #18

Closed jds11111 closed 2 years ago

jds11111 commented 2 years ago

Do these entities not have device_class: temperature ?

mawinkler commented 2 years ago

They do state_class: measurement attribution: Powered by 7Timer unit_of_measurement: °C device_class: temperature icon: mdi:thermometer friendly_name: Astroweather 2m Temperature

jds11111 commented 2 years ago

Oddly, the forecast temperature converts to the default units fine, but the current temp stays in deg C only.

mawinkler commented 2 years ago

Are you referring to the lovelace card? If so, this is now fixed with the latest release

jds11111 commented 2 years ago

I saw that fix. I make a plot with data scraped from different sources for a different dashboard card, and the astroweather one is the only one that stays in C: image

MisterTFM commented 2 years ago

Are you referring to the lovelace card? If so, this is now fixed with the latest release

Thanks for correcting the Lovelace card, it now displays in F and MPH.

However, it still shows precipitation rate in mm/hour vs. inches/hour

ScreenHunter 357

ALSO, the displayed CIVIL sunrise times are 30 minutes too early and CIVIL sunset times are 30 minutes too late according to my LAT and LON. ScreenHunter 361 .

mawinkler commented 2 years ago

For the sun, I'm calculating the twilights for the center of the object not for the upper edge as some do. This matches with Stellarium and SkySafari 6 Pro.

In regards to the unit conversion, I just pushed 0.22.2 which should resolve the issue. I didn't create a release yet, so you would need to redownload astroweather from the main branch.

jds11111 commented 2 years ago

That fixed it! The units are now corrected on all the cards. Many thanks.

mawinkler commented 2 years ago

thank you for reporting back 🎉

MisterTFM commented 2 years ago

However, it still shows precipitation rate in mm/hour vs. inches/hour

I'm still seeing percipitation rate in mm/hr vs. inches/hour. ScreenHunter 371

mawinkler commented 2 years ago

This is because the text is currently defined in constants. I will add that to my to-do list for later. This is what I'm working on now.