mawkler / modicator.nvim

Cursor line number mode indicator plugin for Neovim
MIT License
298 stars 6 forks source link

Exiting command popup when using noice doesn't seem to register #7

Closed cphorton closed 1 year ago

cphorton commented 1 year ago

Hi, and thanks for the nice little plugin.

This is a very minor issue when using noice https://github.com/folke/noice.nvim and it's command popup window. When exiting the command window, or completing a command the editor will go back to normal mode, but modicator is still showing command mode being active. Subsequent mode changes e.g. into insert mode will still work fine.

I have only witnessed this occurring when using noice, but I guess it could happen with other plugins too.

As I said, it is a very minor issue, but thought I would bring it to your attention.

Thanks

mawkler commented 1 year ago

Hi @cphorton! This seems to be an issue with noice.nvim not triggering the autocommand ModeChanged when exiting command-line mode. I've created an issue here folke/noice.nvim/issues/390.

cphorton commented 1 year ago

Hi @cphorton! This seems to be an issue with noice.nvim not triggering the autocommand ModeChanged when exiting command-line mode. I've created an issue here folke/noice.nvim/issues/390.

Great, thanks for looking into it and creating the issue

mawkler commented 1 year ago

@cphorton This has now been fixed by https://github.com/folke/noice.nvim/pull/396. Let me know if you have any more issues 🙂