YouTube + Music

[Titiftw]

Hi, I found your project and I really enjoyed it. However, it was lacking few functionalities that I tried to add myself. Note that I am not a Python nor a Svelte expert but if it may help you, it includes Music upload and YouTube (that one might require some fanciness on the link input). I'm missing software for the translations though.

If you think this can help you, feel free to use it. If not, then please discard that PR!

Kind regards, Jason

[mawoka-myblock]

Thank you soo much for this PR! Really appreciate it! I've just looked through the code roughly and put some notes down. Please address them or comment on them and mark them as resolved afterwards. Another thing I haven't seen: Where's the YouTube player? maybe I just missed it. I'll also have to test this code locally. Again, many thanks for such a huge PR!

[Titiftw]

Owner

The YouTube player is done using iframe: Once the link is added to the card, it gets displayed on it: Might still be missing from the Admin card as I didn't test it fully as I realized that the YouTube video title would be showed to every body... Not the greatest idea for Blind tests.

[Titiftw]

@mawoka-myblock I'm having issue "unlinking" images/musics from a quiz. If I remove a music or an image from a quiz and it becomes unused in any quiz, the call "/storage/list" still shows it as part of a quiz which prevents the file delete button to appear. It seems that the storage worker line await new_quiz.storageitems.remove(item) always fails as the item UUID doesn't exist. Any idea what's wrong?

[mawoka-myblock]

I'm gonna have to look into that when I got time. Expect the weekend in 3 days

[mawoka-myblock]

I haven't forgotten you yet!

[Titiftw]

No worries @mawoka-myblock, take your time! In the meantime, I also worked on another feature to fix several points which were blocking my tests:

• [x] When playing, there was a bug when a player would reconnect more than once which could potentially happen. I fixed it in my feature branch (now the player can refresh any time the game, as long as it is not answering a question).
• [x] When playing, the total score showed on the player screen was wrong if the player reconnected.
• [x] When playing, a player could give X answers if it would click X times on the "Validate" button. I adjusted the disabled button logic in the frontend and also return an "already_replied" on the WebSocket.
• [x] When playing on a CHECK question, the player could select multiple answers. I made sure all the selected answers were removed when clicking on another answer.
• [x] I also made few styles fixes (annoying scrollbar when playing for instance).

I'll create another PR if you don't mind!

[mawoka-myblock]

Okay, so I got it installed and here are some things I noticed:

• The music upload does not work
  • Why create a new endpoint for the music upload? Why not resuse the video one?
  • After the upload, the popup closes but nothing happens on in the editor
• YouTube URL input definitely needs some cosmetic work
• YouTube doesn't autoplay on the play page
• YouTube video isn't centered
• The "Old School" mode doesn't have the YouTube video on the player's screens

I could fix them myself, though some need an explanation on your side ;)

[mawoka-myblock]

The "view" page also seems to be missing the Youtube player, just like the "Practice" mode

[Titiftw]

Hi @mawoka-myblock, let me answer your questions:

• The music upload does not work
  • Why create a new endpoint for the music upload? Why not resuse the video one? => Because I wanted to have the filename stored; otherwise it is complicated to find back the song in the library - which I didn't find supported by the video upload endpoint.
  • After the upload, the popup closes but nothing happens on in the editor => You're right, I typically then used the Library to add the music onto the slide. I'll have a look.
• YouTube URL input definitely needs some cosmetic work => I'll propose something but styling is not my cup of tea.
• YouTube doesn't autoplay on the play page => I'll provide a fix.
• YouTube video isn't centered => Same.
• The "Old School" mode doesn't have the YouTube video on the player's screens => Same.
• The "view" page also seems to be missing the Youtube player, just like the "Practice" mode => Same.