Closed mawosoft closed 2 years ago
0.13.1.1696 vs 0.13.1.0
Affects WhatifFilter
, ColumnCategoryExtensions
# class BenchmarkReport (BenchmarkDotNet.Reports)
public BenchmarkReport (bool success, BenchmarkDotNet.Running.BenchmarkCase benchmarkCase,
BenchmarkDotNet.Toolchains.Results.GenerateResult generateResult,
BenchmarkDotNet.Toolchains.Results.BuildResult buildResult,
System.Collections.Generic.IReadOnlyList<BenchmarkDotNet.Toolchains.Results.ExecuteResult> executeResults,
- System.Collections.Generic.IReadOnlyList<Measurement> allMeasurements,
- BenchmarkDotNet.Engines.GcStats gcStats,
System.Collections.Generic.IReadOnlyList<Metric> metrics);
Measurements and gcStats are now part of ExecuteResult. ExecuteResult doesn't accept a Measurement
collection, but will instead parse the lines output from execution itself (but see the new internal ctor).
# class ExecuteResult (BenchmarkDotNet.Toolchains.Results)
public ExecuteResult (bool foundExecutable, int? exitCode, int? processId,
System.Collections.Generic.IReadOnlyList<string> data,
System.Collections.Generic.IReadOnlyList<string> linesWithExtraOutput
+, int launchIndex
);
+internal ExecuteResult(List<Measurement> measurements, GcStats gcStats, ThreadingStats threadingStats)
-public System.Collections.Generic.IReadOnlyList<string> Data { get; }
+public System.Collections.Generic.IReadOnlyList<string> Errors { get; }
+public bool IsSuccess { get; }
+public System.Collections.Generic.IReadOnlyList<BenchmarkDotNet.Reports.Measurement> Measurements { get; }
+public void LogIssues (BenchmarkDotNet.Loggers.ILogger logger, BuildResult buildResult);
more?
Various breaking changes in the public API of BDN between official release 0.13.1 and current CI/nightly build can cause problems, e.g. changed ctors for BenchmarkAttribute and BenchmarkReport.
Also research possible cases where we use the internal/private API via reflection.
As a starting point, see: https://devblogs.microsoft.com/dotnet/package-validation/ https://github.com/mattleibow/Mono.ApiTools.NuGetDiff