search

mawww / kakoune

mawww's experiment for a better code editor
http://kakoune.org
The Unlicense
9.7k stars 706 forks source link

x11-repl does not work with termite #3011

Open JJK96 opened 5 years ago

JJK96 commented 5 years ago

Steps 

set buffer termcmd 'termite -e'
x11-repl

Outcome

termite is started but immediately closes

Expected

termite is started and stays open

Probable cause

The -e flag to termite does not support passing multiple commands using && as is done in repl/x11.kak

lenormf commented 5 years ago

termite -e executes the command passed as argument as-is, it doesn't pass it to a shell - you had the right diagnosis. And setting termcmd to termite -e sh -c won't work either because Termite expects the command to be passed as a single CLI argument, i.e. the resulting command has to be termite -e 'sh -c "$CMD"'.

It was bound to happen one day or the other, the way termcmd is being used by scripts might have to be modified to fix this bug.

lenormf commented 4 years ago

It looks like Tilix also suffers from the same issue. Doesn't look like the commands are forwarded to a shell.