max-ieremenko
commented
8 months ago https://github.com/Cysharp/MemoryPack/issues/188 ... Unlike protobuf-net and MessagePack for C#, you first need to make it partial ...
Making Messages classes partial won't help: for your project Message(<,>) is external-type. see Serialize external types.
Or maybe there is some other way to solve this?
An example of the MemoryPackMarshaller draft:
public sealed class MemoryPackJsonMarshallerFactory : IMarshallerFactory
{
public static readonly IMarshallerFactory Default = new MemoryPackJsonMarshallerFactory();
static MemoryPackJsonMarshallerFactory()
{
MemoryPackFormatterProvider.RegisterGenericType(typeof(Message<>), typeof(MessageMemoryPackFormatter<>));
// TODO: implement MemoryPackFormatterProvider.RegisterGenericType(typeof(Message<,>), typeof(MessageMemoryPackFormatter<,>));
}
public Marshaller<T> CreateMarshaller<T>() => new(Serialize, Deserialize<T>);
private static void Serialize<T>(T value, SerializationContext context)
{
var bufferWriter = context.GetBufferWriter();
MemoryPackSerializer.Serialize(bufferWriter, value);
context.Complete();
}
private static T Deserialize<T>(DeserializationContext context)
{
return MemoryPackSerializer.Deserialize<T>(context.PayloadAsReadOnlySequence())!;
}
}
// TODO implement internal readonly partial struct SerializableMessage<T1, T2>
[MemoryPackable]
internal readonly partial struct SerializableMessage<T>
{
internal readonly Message<T> Message;
[MemoryPackInclude]
public T Value => Message.Value;
[MemoryPackConstructor]
public SerializableMessage(T value)
{
Message = new Message<T>(value);
}
public SerializableMessage(Message<T> message)
{
Message = message;
}
}
// TODO implement internal sealed class MessageMemoryPackFormatter<T1, T2>
internal sealed class MessageMemoryPackFormatter<T> : MemoryPackFormatter<Message<T>>
{
public override void Serialize<TBufferWriter>(ref MemoryPackWriter<TBufferWriter> writer, scoped ref Message<T>? value)
{
ArgumentNullException.ThrowIfNull(value);
writer.WritePackable(new SerializableMessage<T>(value));
}
public override void Deserialize(ref MemoryPackReader reader, scoped ref Message<T>? value)
{
if (reader.PeekIsNull())
{
throw new NotSupportedException();
}
var wrapped = reader.ReadPackable<SerializableMessage<T>>();
value = wrapped.Message;
}
}Test
MemoryPackFormatterProvider.RegisterGenericType(typeof(Message<>), typeof(MessageMemoryPackFormatter<>));
var input = new Message<string>("foo");
var payload = MemoryPackSerializer.Serialize(input);
var actual = MemoryPackSerializer.Deserialize<Message<string>>(payload);
actual.ShouldNotBeNull();
actual.Value.ShouldBe("foo");
De-Crypted
Is your feature request related to a problem? Please describe. I was trying to implement custom marshaller for MemoryPack (https://github.com/Cysharp/MemoryPack) but I quickly learned it wouldn't work. The internally used
Messageclass could not be serialized and the reason for this is that MemoryPack does not support [DataContract] attribute nor do they plan on supporting it (https://github.com/Cysharp/MemoryPack/issues/188).What MemoryPack requires is to make the class partial and annotate it with [MemoryPackable] attribute.
Describe the solution you'd like Could the Message class be exposed as partial class so that it could be annotated with [MemoryPackable], I think this should allow Source Generator to do it's things (not 100% sure).
Or maybe there is some other way to solve this?
Anyways, thank you for this library. I'm enjoying it very much.