search

max-kammerer / orion-viewer

Orion Viewer is pdf, djvu, xps, cbz and tiff file viewer for Android devices based on mupdf and DjVuLibre libraries
Other
159 stars 52 forks source link

Changing indivual book, and or default book Color Mode in 92.1 and 92.2 does not work at all. #49

Closed Smutley closed 3 months ago

Smutley commented 4 months ago

Changing indivual book, and or default book Color Mode in 92.1 and 92.2 does not work at all.

While it has always been awkward, and often niggley, changing Color Mode for individual books, and or as a default, at least worked. The last two releases it does not work at all, and the "default" color is always shown regardless of setting.

max-kammerer commented 3 months ago

@Smutley thank you for the report. I will look into it.

Could you please add additional detail about this part "While it has always been awkward, and often niggley", what was wrong in case when this option worked

max-kammerer commented 3 months ago

@Smutley I've made several fixes. You can try the latest beta version to test the corrected behavior: https://sourceforge.net/projects/orion-viewer/files/

Smutley commented 3 months ago

Your changes in 92.3 make the color mode work more or less as in earlier than 92.2 releases.

However, setting default color mode only works if a document is open when a color change is made. Nor will it reliably work unless one changes to yet another color mode, and then changes to the desired color mode. In other words it does not work as expected.

max-kammerer commented 3 months ago

@Smutley The logic behind option is next: default option works for current opened book and for all new books that would be open in future. There is also "color mode" option for current book in "[Current] Book option" (it's separate menu item)

Nor will it reliably work unless one changes to yet another color mode, and then changes to the desired color mode

I don't understand this part. Maybe you can add additional details, how to reproduce the problem and what are initial setting to start with

max-kammerer commented 3 months ago

@Smutley I'm closing this issue as original problem was fixed. If you have any ideas about option logic improvements please report new issue