Closed iNuman closed 1 month ago
@iNuman Thank you very much for your contribution, improvements in texts selection are welcome! In the same time very similar things were already made in the penultimate release, 0.94.4. Could you please check these changes and rebase on master? (In 0.94.4 there were introduced new type of selection: selection by lines (that is triggered by long tap) in additional to selection by rectangle area (that can be invoked from menu), also expansion handles were added)
Highlight Text Feature: The copy button in the popup menu now also highlights the selected text.
Could you please clarify reasoning for this feature?
@iNuman Thank you very much for your contribution, improvements in texts selection are welcome! In the same time very similar things were already made in the penultimate release, 0.94.4. Could you please check these changes and rebase on master? (In 0.94.4 there were introduced new type of selection: selection by lines (that is triggered by long tap) in additional to selection by rectangle area (that can be invoked from menu), also expansion handles were added)
Highlight Text Feature: The copy button in the popup menu now also highlights the selected text.
Could you please clarify reasoning for this feature?
@max-kammerer I just checked v0.94.4 you had done great effort how ever there are issue that can be fix by comparing it with my PR :
A pdf user always expect to that he'll long press, select text and selected text should highlight.
https://github.com/max-kammerer/orion-viewer/assets/25281036/f8341e01-c9c3-4114-9cef-ab1d585ff96c
Hi @iNuman, if you want to implement smth I think it could be a good idea to discuss feature and its design in advance
I have made significant advancements to the text selection feature in the following ways:
Control Points on Long Press: On a long press, users now see two control points along with the default selection, allowing for easier text manipulation.
Improved Selection Expansion: Users can now drag these control points to adjust the selection, simplifying the process compared to the previous method where users needed to move their finger to draw a rectangle.
Highlight Text Feature: The copy button in the popup menu now also highlights the selected text.
Attached is a video showcasing these improvements.
https://github.com/max-kammerer/orion-viewer/assets/25281036/3b4168e1-6098-4daf-bc09-82495a5a1bb8
@max-kammerer , Could you please review and merge this pull request so the community can benefit from these enhancements?
Thank you for your time and consideration.